Accept Homebrew revision suffix in LLVM version parsing - #557
Merged
Conversation
Homebrew published llvm 22.1.7_1, where the trailing _1 is a bottle revision (a rebuild of the same upstream version). The version validation regex only accepted bare X.Y.Z, so it rejected the _N suffix and failed the "Setup homebrew packages" step in every C++ job. Widen the regex to accept an optional _N revision suffix. The parsed value feeds compiler.abi_extra in the Conan sanitizers profile, so keeping the suffix is correct: a Homebrew rebuild should invalidate the Conan ABI discriminator and trigger a rebuild.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Homebrew LLVM version parsing in the CI setup action to handle Homebrew “bottle revision” suffixes (e.g., 22.1.7_1), preventing C++ jobs from failing during the “Setup homebrew packages” step while preserving the suffix for downstream ABI discrimination.
Changes:
- Expand the LLVM version validation regex to accept an optional
_<revision>suffix (e.g.,_1). - Keep the full version string (including revision) as the parsed value for use in subsequent CI steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew published llvm 22.1.7_1, where the trailing _1 is a bottle revision (a rebuild of the same upstream version). The version validation regex only accepted bare X.Y.Z, so it rejected the _N suffix and failed the "Setup homebrew packages" step in every C++ job.
Widen the regex to accept an optional _N revision suffix. The parsed value feeds compiler.abi_extra in the Conan sanitizers profile, so keeping the suffix is correct: a Homebrew rebuild should invalidate the Conan ABI discriminator and trigger a rebuild.